fix: handle more bdb shutdown interrupts #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gretchenleighmiller
approved these changes
Oct 4, 2025
ato
approved these changes
Oct 5, 2025
|
If I understand Thread.interrupt() properly, it is just setting a flag, but that flag has special connotations for bdb. Maybe giving ToeThread its own requestStop() could replace the call to interrupt() and then switch uses of interrupted() to stopRequested(). Then maybe we wouldn't have to wrap each of the bdb interactions? |
|
I believe Thread.interrupt() also wakes up threads in Thread.sleep(), Object.wait() and other similar methods. So it does in theory have more stopping power than an arbitrary flag would have. How important this is to the Heritrix forceful stop scenario I'm not certain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of the issue being addressed in #659
I encountered this during shutdown and it seems to just be an uncommon race condition where a thread happened to still be adding outlinks to the frontier. The added unit test reproduces the behavior if the
Thread.interrupted()calls aren't present.Maybe something could be done in ToeThread itself to override the
interrupt()function and delay the baseinterrupt()call until it has reached the end of the chain?